Django

Code

Ticket #3788 (closed: fixed)

Opened 2 years ago

Last modified 2 years ago

[patch] newforms.fields.MultiValueField.clean should check for IndexError

Reported by: Max Derkachev <mderk@yandex.ru> Assigned to: adrian
Milestone: Component: Forms
Version: SVN Keywords:
Cc: Triage Stage: Unreviewed
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

MultiValueField?.clean checks for KeyError? while enumerating self.fields, while it should check for IndexError? instead.

Attachments

fields_multivaluefield.patch (0.5 kB) - added by Max Derkachev <mderk@yandex.ru> on 03/23/07 12:24:27.

Change History

03/23/07 12:24:27 changed by Max Derkachev <mderk@yandex.ru>

  • attachment fields_multivaluefield.patch added.

03/23/07 20:17:03 changed by Gary Wilson <gary.wilson@gmail.com>

  • status changed from new to closed.
  • needs_better_patch changed.
  • resolution set to duplicate.
  • needs_tests changed.
  • needs_docs changed.

Marking a duplicate of #3787 since it is mentioned and included in the patch in that ticket.

03/26/07 03:27:33 changed by Max Derkachev <mderk@yandex.ru>

  • status changed from closed to reopened.
  • resolution deleted.

Not a duplicate. #3787 is about widgets.MultiWidget?, not fields.MultiValueField?

04/26/07 07:46:04 changed by russellm

  • status changed from reopened to closed.
  • resolution set to fixed.

(In [5088]) Fixed #3787, #3788 -- Corrected check for IndexError? on MultiValueField?, and fixed the value_from_datadict method for MultiWidgets? to handle Multiwidgets containing Multiwidgets. Also added a testcase walking through the use of MultiWidget/MultiValueField?. Thanks to Max Derkachev for reporting these issues and providing fixes.

Add/Change #3788 ([patch] newforms.fields.MultiValueField.clean should check for IndexError)




Change Properties
Action