django.utils.text.smart_split() does not properly handle unmatched quotes

[ivan.chelubeev@…]

django.utils.text.smart_split() does not properly handle unmatched quotes.

smart_split() eats up last character of the word that begins with an unmatched quote and that quote character itself:

>> text.smart_split("one 'two three")
['one', 'tw', 'three']

Of course unmatched quote in a tag argument string most probably is an error. But result produced by smart_split() ("'two" -> "tw") doesn't leave chances to notice or detect this error until actual use at render time (and may be even further).

Also smart_split()'s doctest still produce syntax error (in spite of #3035).

[ivan.chelubeev@…]

fix for unmatched quote problem, with doctests

[Malcolm Tredinnick]

Thanks for this fix.

Tests should go in the tests/ directory. We don't run the docstrings in the main code, so the examples there are just examples. I've fixed this in this case -- and fixed up a small bug in one of the tests in passing. Merely pointing this out for next time.

[Malcolm Tredinnick]

(In [4870]) Fixed #3733 -- Fixed up quote parsing in smart_split(). Thanks, Ivan Chelubeev.