Opened 19 years ago

Closed 19 years ago

#3715 closed (fixed)

Add Japan specific Field and Widget to localflavor module.

Reported by: makoto tsuyuki <mtsuyuki@…> Owned by: Adrian Holovaty
Component: Contrib apps Version: dev
Severity: Keywords:
Cc: mtsuyuki@… Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Patch to add a jp module to the django.contrib.localflavor module.

Tests are included.

Attachments (2)

jplocalflavor.diff​ (8.2 KB ) - added by makoto tsuyuki <mtsuyuki@…> 19 years ago.
jplocalflavor_refine.diff​ (7.9 KB ) - added by makoto tsuyuki <mtsuyuki@…> 19 years ago.
patch refined

Download all attachments as: .zip

Change History (7)

by makoto tsuyuki <mtsuyuki@…>, 19 years ago

Attachment: jplocalflavor.diff​ added

comment:1 by Simon G. <dev@…>, 19 years ago

Triage Stage: Unreviewed → Ready for checkin

comment:2 by Adrian Holovaty, 19 years ago

Patch needs improvement: set
Triage Stage: Ready for checkin → Accepted

The patch includes this line, which refers to something that does exist:

from validators import jp_postal_code_re

in reply to:  2 comment:3 by makoto tsuyuki <mtsuyuki@…>, 19 years ago

I'm sorry about my rubbish patch.

I made my django code clean and worked again.

by makoto tsuyuki <mtsuyuki@…>, 19 years ago

Attachment: jplocalflavor_refine.diff​ added

patch refined

comment:4 by Chris Beaven, 19 years ago

Patch needs improvement: unset
Triage Stage: Accepted → Ready for checkin

comment:5 by Adrian Holovaty, 19 years ago

Resolution: → fixed
Status: new → closed

(In [4822]) Fixed #3715 -- Added Japanese package to django.contrib.localflavor. Thanks, Makoto Tsuyuki

Note: See TracTickets for help on using tickets.
Back to Top