Opened 6 hours ago

Last modified 4 hours ago

#36951 closed Bug

log_task_finished signal logs "NoneType: None" when no exception is raised — at Version 4

Reported by: Jacob Walls Owned by: Elias Hernandis
Component: Tasks Version: 6.0
Severity: Release blocker Keywords:
Cc: Jake Howard Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by Jake Howard)

The test provided on ​PR #20722 demonstrates that faux exceptions are logged as NoneType: None by the log_task_finished signal:

======================================================================
FAIL: test_successful_task_no_none_type_in_logs (tasks.test_immediate_backend.ImmediateBackendTestCase.test_successful_task_no_none_type_in_logs)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/jwalls/django/tests/tasks/test_immediate_backend.py", line 238, in test_successful_task_no_none_type_in_logs
    self.assertNotIn("NoneType", log_output)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 'NoneType' unexpectedly found in 'INFO:django.tasks:Task id=1yKnLbcmTGMEUfj0B1JG0766LDM1Sono path=tasks.tasks.noop_task state=SUCCESSFUL\nNoneType: None'

----------------------------------------------------------------------

Change History (4)

comment:1 by Jacob Walls, 6 hours ago

Triage Stage: Unreviewed → Ready for checkin

​PR

comment:2 by Jacob Walls, 6 hours ago

Opening the ticket as a courtesy, accepting as a triager.

comment:3 by Jacob Walls, 6 hours ago

Needs documentation: set
Triage Stage: Ready for checkin → Accepted

comment:4 by Jake Howard, 6 hours ago

Description: modified (diff)
Has patch: set
Note: See TracTickets for help on using tickets.
Back to Top