task_finished signal logs "NoneType: None" when no exception is raised
The test provided on PR #20722 demonstrates that faux exceptions are logged as NoneType: None by the log_task_finished signal handler:
======================================================================
FAIL: test_successful_task_no_none_type_in_logs (tasks.test_immediate_backend.ImmediateBackendTestCase.test_successful_task_no_none_type_in_logs)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/Users/jwalls/django/tests/tasks/test_immediate_backend.py", line 238, in test_successful_task_no_none_type_in_logs
self.assertNotIn("NoneType", log_output)
~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 'NoneType' unexpectedly found in 'INFO:django.tasks:Task id=1yKnLbcmTGMEUfj0B1JG0766LDM1Sono path=tasks.tasks.noop_task state=SUCCESSFUL\nNoneType: None'
----------------------------------------------------------------------
Change History
(5)
| Triage Stage: |
Unreviewed → Ready for checkin
|
| Needs documentation: |
set
|
| Triage Stage: |
Ready for checkin → Accepted
|
| Description: |
modified (diff)
|
| Has patch: |
set
|
| Description: |
modified (diff)
|
| Needs documentation: |
unset
|
| Summary: |
log_task_finished signal logs "NoneType: None" when no exception is raised → task_finished signal logs "NoneType: None" when no exception is raised
|
| Triage Stage: |
Accepted → Ready for checkin
|
PR