Opened 6 hours ago
Last modified 4 hours ago
#36951 closed Bug
log_task_finished signal logs "NoneType: None" when no exception is raised — at Initial Version
| Reported by: | Jacob Walls | Owned by: | Elias Hernandis |
|---|---|---|---|
| Component: | Tasks | Version: | 6.0 |
| Severity: | Release blocker | Keywords: | |
| Cc: | Jake Howard | Triage Stage: | Ready for checkin |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
The test provided on #20722 demonstrates that faux exceptions are logged as NoneType: None by the log_task_finished signal:
====================================================================== FAIL: test_successful_task_no_none_type_in_logs (tasks.test_immediate_backend.ImmediateBackendTestCase.test_successful_task_no_none_type_in_logs) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/jwalls/django/tests/tasks/test_immediate_backend.py", line 238, in test_successful_task_no_none_type_in_logs self.assertNotIn("NoneType", log_output) ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^ AssertionError: 'NoneType' unexpectedly found in 'INFO:django.tasks:Task id=1yKnLbcmTGMEUfj0B1JG0766LDM1Sono path=tasks.tasks.noop_task state=SUCCESSFUL\nNoneType: None' ----------------------------------------------------------------------
Note:
See TracTickets
for help on using tickets.