Opened 97 minutes ago

Last modified 21 minutes ago

#36893 assigned Bug

MigrationWriter doesn't serialise elidable kwarg

Reported by: Leigh Greville Owned by: SnippyCodes
Component: Migrations Version: 6.0
Severity: Normal Keywords: migrations runsql
Cc: Jarek Glowacki Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

If a migration has elidable RunSQL operations and is serialised by MigrationWriter, they will be serialised without the elidable kwarg. This means they will now be treated as unelidable.

This issue came up for me recently when automatically generating a migration to remove stale tables/columns: the generated migration contains elidable RunSQL operations to drop the stale data, but when they are serialised they are no longer marked as elidable.

This has likely not cropped up before, as MigrationWriter is typically used by the squash command, which never needs to write the operation (cause it gets thrown away if it's elidable).

Someone from my company can pick this up if it's accepted

Change History (3)

comment:1 by Jarek Glowacki, 96 minutes ago

Cc: Jarek Glowacki added

comment:2 by SnippyCodes, 45 minutes ago

Owner: set to SnippyCodes
Status: newassigned

comment:3 by SnippyCodes, 21 minutes ago

Has patch: set
Note: See TracTickets for help on using tickets.
Back to Top