Opened 88 minutes ago
#36744 assigned Cleanup/optimization
Improve/correct scrypt password hasher documentation
| Reported by: | Dmitry Chestnykh | Owned by: | Dmitry Chestnykh |
|---|---|---|---|
| Component: | Documentation | Version: | dev |
| Severity: | Normal | Keywords: | |
| Cc: | Dmitry Chestnykh | Triage Stage: | Unreviewed |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
The current documentation for scrypt password hasher lacks some constraints and definitions:
- work_factor: described incompletely, missing the requirement that this value must be a power of 2
- block_size: has no description
- parallelism: needs to be defined, perhaps, as "independent computations" rather than "threads", because the current OpenSSL implementation is not multithreaded.
If OpenSSL becomes multithreaded, the "Estimating memory usage" note also needs to be adjusted to account for parallelism.
I think it would also be helpful to mention that these parameters are N, r, p, as these are standard terminology for those familiar with scrypt.
I'll send a pull request shortly.
Note:
See TracTickets
for help on using tickets.