Django

Code

Ticket #3640 (closed: fixed)

Opened 2 years ago

Last modified 1 year ago

Missing or mistyped 'language' parameter on /i18n/setlang/ raises a MultiValueDictKeyError

Reported by: Jorge Gajon <gajon@gajon.org> Assigned to: hugo
Milestone: Component: Internationalization
Version: SVN Keywords: i18n
Cc: Triage Stage: Ready for checkin
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

Django provides a setlang/ url which calls django.views.i18n.set_language(). This view expects to find a language paremeter in request.GET, but when this parameter is missing (or was mistyped) an exception is raised; which will generate 500 Server Error pages in production sites.

Attached is a very simple patch. When the language parameter is missing the view will behave as if the language specified was invalid.

Attachments

i18n_set_language.diff (0.9 kB) - added by Jorge Gajon <gajon@gajon.org> on 03/02/07 20:15:37.
Avoid MultiValueDictKeyError? in set_language() view

Change History

03/02/07 20:15:37 changed by Jorge Gajon <gajon@gajon.org>

  • attachment i18n_set_language.diff added.

Avoid MultiValueDictKeyError? in set_language() view

03/02/07 23:00:18 changed by Simon G. <dev@simon.net.nz>

  • keywords set to i18n.
  • needs_better_patch changed.
  • stage changed from Unreviewed to Ready for checkin.
  • needs_tests changed.
  • needs_docs changed.

03/12/07 04:21:22 changed by mtredinnick

  • status changed from new to closed.
  • resolution set to fixed.

(In [4708]) Fixed #3640 -- Improved error handling in views.i18n.set_language(). Thanks Jorge Gajon.

Add/Change #3640 (Missing or mistyped 'language' parameter on /i18n/setlang/ raises a MultiValueDictKeyError)




Change Properties
Action