#3546 closed (invalid)
Add timestamp and user for edits to Comment/FreeComment in contrib.comments
| Reported by: | Owned by: | Adrian Holovaty | |
|---|---|---|---|
| Component: | contrib.comments | Version: | dev |
| Severity: | Keywords: | comments, moderation, contrib, edit | |
| Cc: | Triage Stage: | Design decision needed | |
| Has patch: | no | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
In benchmarking Django's contrib.comments implementation against other frameworks that offer site-wide comments, there are subtle variations in the model used to represent the actual comments. Django's comments provide for some valuable extensions, but seem to be missing something that many other implementations have: fields for the user that last edited a comment and the time at which that edit was made.
This actually seems a bit odd since care was taken with ModeratorDeletion to provide for a record of removal of given comment. However, cases when a moderator would prefer to edit the comment instead of marking it deleted.
Proposal is to add the eqivalent of edit_date and edit_user to the comments implementation. This seems to be a common pattern in models offering similar functionality.
Change History (4)
comment:1 by , 17 years ago
| Triage Stage: | Unreviewed → Design decision needed |
|---|
comment:2 by , 17 years ago
| Resolution: | → invalid |
|---|---|
| Status: | new → closed |
Actually, the goal of the comments rewrite is such that you'll hopefully be able to add in anything you need or want, so I'm going to close this as invalid for now -- we'll revisit this when the comments rewrite comes up (which will be sometime after the 0.96 release).
comment:3 by , 17 years ago
Ok, I've listed all the comments requests that I can find on FeatureGrouping to help the rewriter (Jacob?) to track down what's valid or not.
The comments app will be rewritten prior to 1.0, so I've marked this as Design Decision needed.