NumberInput min_value attr overridden by IntegerField.widget_attrs

[mitch99]

Given this:

widgets = {
   "weight": forms.NumberInput(attrs={'type':'range', 'step': '1', 'min': '1', 'max': '5'),
}

I expect the min value on the range input to be 1, but it's actually 0:

<input type="range" name="form-2-weight" value="3" step="1" min="0" max="5" aria-describedby="id_form-2-weight_helptext" id="id_form-2-weight">

[Sarah Boyce]

This is missing information to determine whether this is a bug or not, I need to see the how the form is defined and how the field weight is defined on the model.

[mitch99]

Please see below:

class ContentProfileDefinitionForm(forms.ModelForm):
    class Meta:
        model = ContentProfileDefinition
        fields = ["other", "weight"]
        widgets = {
            "weight": forms.NumberInput(
                attrs={
                    "type": "range",
                    "step": "1",
                    "min": "1",
                    "max": "5",
                }
            ),
        }
        validators = {
            "weight": [
                MinValueValidator(1),
                MaxValueValidator(5),
            ]
        }

class ContentProfileDefinition(models.Model):
    other = models.ForeignKey("Other", on_delete=models.CASCADE)
    weight = models.PositiveSmallIntegerField(
        default=1,
        help_text="Weight",
        validators=[
            MinValueValidator(1),
            MaxValueValidator(5),
        ],
    )

[mitch99]

Managed to reopen this ticket

[mitch99]

Strangely it's not an off-by-one. It seems the min value is ignored and always set to 0.

[Tim Graham]

The root cause is that Field.__init__() ​overrides a widget's attrs with Field.widget_attrs which includes min_value=0 from ​PositiveIntegerField.formfield().

I'm not sure if we should change the behavior. The most appropriate fix for your use case might be to subclass PositiveIntegerField and override formfield() to set min_value=1.

[David Sanders]

Yup what Tim said: There will be people relying on this existing behaviour 👍

Another way to get min="1" is to use django-widget-tweaks: ​https://github.com/jazzband/django-widget-tweaks I just tested it out and it works 👍

[mitch99]

OK thanks I'll try these approaches.