Admin fieldset multiple flexbox regressions

[minusf]

Hello. I have noticed a couple regressions in the admin fieldset css. I think they are all related to switching <div class="form-row"> to flexbox.

1. input type=text boxes on the right side grow in height if the label doesn't fit into 160px.

2. long labels have uncovered another issue: incorrect line height and a forced height in general. After applying the following patch:

M django/contrib/admin/static/admin/css/forms.css
@@ -84,14 +84,13 @@ form ul.inline li {
     min-width: 160px;
     width: 160px;
     word-wrap: break-word;
-    line-height: 1;
+    line-height: 1.5;
 }
 
 .aligned label:not(.vCheckboxLabel):after {
     content: '';
     display: inline-block;
     vertical-align: middle;
-    height: 1.625rem;
 }
 
 .aligned label + p, .aligned .checkbox-row + div.help, .aligned label + div.readonly {

long labels looks more readable:

3. checkboxes are not aligned with their labels. I don't have a patch for this, only 2 screenshots:

with flexbox:

without flexbox:

[Sarah Boyce]

Thank you for the report and screenshots! Replicated 👍

For reference, this is how these examples looked on 4.1 (ignore the red dot)

1 and 3 are regressions from 96a598356a9ea8c2c05b22cadc12e256a3b295fd, 2 is a long standing issue.

Unsure what is the best option for 1, because the grow behaviour looks better when there is help text.
Happy to receive suggestions or to default to the previous behaviour.

[minusf]

Thank your for looking into this. Interesting that for so long nobody reported this.

I am sorry but I think the help_text is not helping much, personally my eyes are still bleeding ;-)

If you are happy with the patch for the height issue (no 2.), I can start a pull request and work from there.

The first couple of "fixes" I tried were not effective and it seems like I have to dive into flex myself much deeper as my understanding of it is flawed.

[Sarah Boyce]

If you are happy with the patch for the height issue (no 2.), ...

I think you can also remove the line-height

M django/contrib/admin/static/admin/css/forms.css
@@ -84,14 +84,13 @@ form ul.inline li {
     min-width: 160px;
     width: 160px;
     word-wrap: break-word;
-    line-height: 1;
 }
 
 .aligned label:not(.vCheckboxLabel):after {
     content: '';
     display: inline-block;
     vertical-align: middle;
-    height: 1.625rem;
 }

Looks ok to me

..., I can start a pull request and work from there.

Please do! I also think (2) should be a separate commit to (1) and (3) (maybe a commit message something like... Refs #35404 -- Fixed line height of admin fieldset labels.)