#34691 closed Cleanup/optimization (fixed)
Add a system check for unmatched URL paths' < / >
| Reported by: | Adam Johnson | Owned by: | Amir Karimi |
|---|---|---|---|
| Component: | Core (System checks) | Version: | dev |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Ready for checkin | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
Currently, unmatched angle brackets are silently ignored:
path('<int:question_id/vote/', views.vote, name='vote'),
This leads to a frustrating debugging experience, where a 404 or NoReverseMatch could occur and only the eagle-eyed could spot why. Similar to the ^/$ system check added in #28663, I propose a new check in RoutePattern.check() for unmatched < or >. It's rather unlikely those characters are legitimately used in URLs.
(Inspired by a new user making this mistake and asking for help on the forum.)
Change History (7)
comment:1 by , 2 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
comment:2 by , 2 years ago
| Component: | Core (URLs) → Core (System checks) |
|---|---|
| Triage Stage: | Unreviewed → Accepted |
Sounds reasonable, this should raise a system check warning, not an error.
comment:4 by , 2 years ago
| Patch needs improvement: | set |
|---|
comment:5 by , 2 years ago
| Patch needs improvement: | unset |
|---|---|
| Triage Stage: | Accepted → Ready for checkin |
Note:
See TracTickets
for help on using tickets.
Seems essential. I can work on it by splitting the routes based on '/' and checking if each part having started with '<' must have ended with '>'.