Opened 3 years ago

Closed 23 months ago

#34411 closed Cleanup/optimization (fixed)

Update obsolete GDAL API for DataSource handling

Reported by: Claude Paroz Owned by: Claude Paroz
Component: GIS Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Some part of the GDAL API is deprecated and we should sooner or later move to the new API (available since GDAL 2.0).

I have a WIP patch, but was unable to make the OGROpen -> GDALOpenEx switch, as the API is different. I need someone more familiar with C interfaces to come and help finish the patch.

Change History (7)

comment:1 by Claude Paroz, 3 years ago

​WIP PR

comment:2 by Mariusz Felisiak, 3 years ago

Triage Stage: Unreviewed → Accepted

comment:3 by stimver, 3 years ago

Owner: changed from nobody to stimver
Status: new → assigned

comment:4 by Claude Paroz, 3 years ago

For anyone passing by, the C signature of GDALOpenEx is:
GDALDatasetH GDALOpenEx(const char *pszFilename, unsigned int nOpenFlags, const char *const *papszAllowedDrivers, const char *const *papszOpenOptions, const char *const *papszSiblingFiles)

The trick is to find the ​ctypes equivalent signature.

comment:5 by Claude Paroz, 23 months ago

Patch needs improvement: unset

Patch should be reviewable now, thanks to David Smith!

comment:6 by Mariusz Felisiak, 23 months ago

Owner: set to Claude Paroz
Triage Stage: Accepted → Ready for checkin

comment:7 by Mariusz Felisiak <felisiak.mariusz@…>, 23 months ago

Resolution: → fixed
Status: assigned → closed

In 08306bad:

Fixed #34411 -- Updated GDAL API to handle vector DataSource's.

Co-authored-by: David Smith <smithdc@…>

Note: See TracTickets for help on using tickets.
Back to Top