Opened 3 years ago

Closed 2 years ago

#34362 closed Bug (fixed)

FilteredRelation doesn’t support conditional expression

Reported by: zhu Owned by: Francesco Panico
Component: Database layer (models, ORM) Version: 4.1
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description 

    def test_conditional_expression(self):
        self.assertSequenceEqual(
            Author.objects.annotate(
                the_book=FilteredRelation(
                    "book",
                    condition=Q(
                        Value(False)
                        ),
                ),
            )
            .filter(
                the_book__isnull=False,
            ),
            [],
        )

Change History (16)

comment:1 by Mariusz Felisiak, 3 years ago

Component: Uncategorized → Database layer (models, ORM)
Triage Stage: Unreviewed → Accepted
Type: Uncategorized → Bug

comment:2 by Francesco Panico, 3 years ago

Owner: changed from nobody to Francesco Panico
Status: new → assigned

comment:3 by Francesco Panico, 3 years ago

Has patch: set

​PR

comment:4 by Mariusz Felisiak, 3 years ago

Patch needs improvement: set

comment:5 by Francesco Panico, 3 years ago

Patch needs improvement: unset

​PR

comment:6 by David Wobrock, 3 years ago

Needs tests: set
Patch needs improvement: set

Adding Needs tests and Patch needs improvement after ​zhu's comment.

comment:7 by Francesco Panico, 3 years ago

Needs tests: unset
Patch needs improvement: unset

comment:8 by Mariusz Felisiak, 3 years ago

Needs tests: set
Patch needs improvement: set

comment:9 by Francesco Panico, 3 years ago

Needs tests: unset
Patch needs improvement: unset

comment:10 by Mariusz Felisiak, 3 years ago

Patch needs improvement: set

We should first fix #33766 so we don't end with an error prone solution.

comment:11 by Francesco Panico, 2 years ago

Patch needs improvement: unset

comment:12 by Mariusz Felisiak <felisiak.mariusz@…>, 2 years ago

In afc8805:

Refs #34362 -- Added get_child_with_renamed_prefix() hook.

comment:13 by Mariusz Felisiak, 2 years ago

Patch needs improvement: set

comment:14 by Francesco Panico, 2 years ago

Patch needs improvement: unset

comment:15 by Mariusz Felisiak, 2 years ago

Triage Stage: Accepted → Ready for checkin

comment:16 by Mariusz Felisiak <felisiak.mariusz@…>, 2 years ago

Resolution: → fixed
Status: assigned → closed

In 59f47547:

Fixed #34362 -- Fixed FilteredRelation() crash on conditional expressions.

Thanks zhu for the report and Simon Charette for reviews.

Note: See TracTickets for help on using tickets.
Back to Top