Django

Code

Ticket #3428 (closed: wontfix)

Opened 2 years ago

Last modified 1 week ago

[full-history] Small fixes to the code

Reported by: ramiro <rm0 _at_ gmx.net> Assigned to: nobody
Milestone: Component: Uncategorized
Version: other branch Keywords:
Cc: Triage Stage: Someday/Maybe
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

This patch fixes:

  • There are some TAB chars indenting the Python code. From the context it can be deduced that they were used to represent 8 spaces.
  • In django/contrib/history/models.py: The Pickle.dumps call in save_new_revision() uses named protocol=0 as a second parameter. It gives me an error under Python 2.3 (and this result in the the save operation failing always) but from the Python 2.5 [1]documentation it's clear than nothing has changed since 2.3 times in that method. The fix is just call it using 0 or not use it at all.

This patch is against the branch code as of [4459]

Attachments

full-history-r4459.diff (9.6 kB) - added by ramiro <rm0 _at_ gmx.net> on 02/04/07 15:25:56.

Change History

02/04/07 15:25:56 changed by ramiro <rm0 _at_ gmx.net>

  • attachment full-history-r4459.diff added.

02/10/07 04:41:09 changed by Simon G. <dev@simon.net.nz>

  • needs_better_patch changed.
  • needs_tests changed.
  • version changed from SVN to other branch.
  • needs_docs changed.
  • has_patch set to 1.
  • stage changed from Unreviewed to Ready for checkin.

03/15/07 11:16:26 changed by utrebec

(In [4739]) [full-history] Refs #3428 -- Removed 'protocol=0' parameter

02/22/08 16:17:50 changed by PJCrosier

  • summary changed from [full-history] [patch] Small fixes to the code to [full-history] Small fixes to the code.

03/17/08 12:29:36 changed by jacob

  • stage changed from Ready for checkin to Someday/Maybe.

10/05/08 21:02:59 changed by mtredinnick

  • status changed from new to closed.
  • resolution set to wontfix.

The full-history branch is inactive and won't be updated any further. Alternate solutions to the problem can be attempted without changing Django's core nearly as much these days (it's a lot more customisable) and approaches are encouraged. But we aren't going to apply patches to the branch.

Add/Change #3428 ([full-history] Small fixes to the code)




Change Properties
Action