URLField does not validate IP addresses, or localhost

[mirrorballu2@…]

This URL http://127.0.0.1:8000/ doesn't validate. I think it should, because that's where Django's own server runs. Also sites can be run without a domain, only using the IP. This doesn't validate either: http://201.27.42.72/

[Simon G. <dev@…>]

I've moved this onto newforms, as this is still an issue there - e.g.:

In [47]: f.clean('http://localhost')
...
ValidationError: [u'Enter a valid URL.']

In [48]: f.clean('http://127.0.0.1')
...
ValidationError: [u'Enter a valid URL.']

In [49]: f.clean('http://208.113.142.170')
...
ValidationError: [u'Enter a valid URL.']

Looking at the regex though, it may be more trouble than it's worth to fix this.

[madssj@…]

Attached patch the allows ip's in the url.

[madssj@…]

url_re patch

[Chris Beaven]

(added tests in the last patch)

I don't really see a design decision required. Promoting to checkin.

[anonymous]

Any chance this could be broken into separate options for the field before getting checked in? From a security standpoint I think it's safer to make programmers dictate they want to accept IPs and non-standard port numbers (IPs and non port 80/443 sites are very commonly used by malware/phishing sites and comment form spammers).

[Russell Keith-Magee]

(In [6152]) Fixed #3421 -- Added IP and localhost validation to newforms URLField. Thanks, SmileyChris.