Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#34154 closed Cleanup/optimization (fixed)

Inconsistent use of "mixin" in the documentation

Reported by: Willem Van Onsem Owned by: Tony Lechner
Component: Documentation Version: 4.1
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

In the documentation on authentication, we see:

The LoginRequired mixin

and further we see:

The PermissionRequiredMixin mixin

In the first, it does not include the Mixin suffix, whereas in the latter, it does. I think it is better to use the latter, since that refers to the real name of the mixin, and furthermore the ​RAS syndrome is usually allowed repeating Mixin twice.

Another option could be to format it with:

The LoginRequiredMixin.

Change History (5)

comment:1 by Tony Lechner, 4 years ago

Owner: changed from nobody to Tony Lechner
Status: new → assigned
Triage Stage: Unreviewed → Accepted

comment:2 by Tony Lechner, 4 years ago

Has patch: set

​PR.

I don't see any other violations of this pattern on cursory greps through the doc tree.

comment:3 by Tony Lechner, 4 years ago

Type: Uncategorized → Cleanup/optimization

comment:4 by GitHub <noreply@…>, 4 years ago

Resolution: → fixed
Status: assigned → closed

In b088cc2:

Fixed #34154 -- Made mixin headers consistent in auth docs.

comment:5 by Mariusz Felisiak <felisiak.mariusz@…>, 4 years ago

In 939bab6:

[4.1.x] Fixed #34154 -- Made mixin headers consistent in auth docs.

Backport of b088cc2feaac638aea91e4d3ab22d276f81630ff from main

Note: See TracTickets for help on using tickets.
Back to Top