Opened 3 years ago

Closed 3 years ago

#34094 closed Bug (fixed)

RTL alignment is off in admin header area

Reported by: Thibaud Colas Owned by: Francesco Panico
Component: contrib.admin Version: 4.1
Severity: Normal Keywords: rtl
Cc: Sarah Abderemane, Shai Berger, Amine Zyad, Francesco Panico Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: yes

Description

There are two RTL spacing / alignment issues in the admin header area which are unrelated but should be straightforward to address at the same time:

  • The h1 "branding" has a left margin, which should be switched to the right for RTL languages
  • The theme switcher’s .theme-toggle’s margin-left should also switch to the right.

Both margins can be switched to use margin-inline-start, so the correct spacing is used in RTL languages. No need to add to the separate RTL-only stylesheet.

Attachments (2)

Screenshot 2022-10-13 at 17.51.52.png​ (119.6 KB ) - added by Thibaud Colas 3 years ago.
Schermata 2022-10-30 alle 02.12.03.png​ (23.3 KB ) - added by Francesco Panico 3 years ago.

Download all attachments as: .zip

Change History (10)

by Thibaud Colas, 3 years ago

Attachment: Screenshot 2022-10-13 at 17.51.52.png​ added

comment:1 by Mariusz Felisiak, 3 years ago

Cc: Sarah Abderemane Shai Berger added
Triage Stage: Unreviewed → Accepted

Thanks for the report!

comment:2 by 1twalters01, 3 years ago

Owner: changed from nobody to 1twalters01
Status: new → assigned

comment:3 by Amine Zyad, 3 years ago

Cc: Amine Zyad added

Anyone working on this?

comment:4 by Mariusz Felisiak, 3 years ago

Owner: 1twalters01 removed
Status: assigned → new

Amine, feel-free to work on this.

comment:5 by Francesco Panico, 3 years ago

Owner: set to Francesco Panico
Status: new → assigned

comment:6 by Francesco Panico, 3 years ago

Is the margin on div#branding h1 a right margin, that should be turned into a left margin for RTL languages?

by Francesco Panico, 3 years ago

Attachment: Schermata 2022-10-30 alle 02.12.03.png​ added

comment:7 by Francesco Panico, 3 years ago

Cc: Francesco Panico added
Has patch: set

​PR

comment:8 by Mariusz Felisiak, 3 years ago

Resolution: → fixed
Status: assigned → closed

Fixed in c01e76c95caa1bd2995f1b6c186cbe8726c92ef9.

Note: See TracTickets for help on using tickets.
Back to Top