Opened 4 years ago

Closed 4 years ago

#33340 closed Bug (fixed)

DatabaseCache backend doesn't quote all fields in queries

Reported by: Tim Graham Owned by: Arsalan Ghassemi
Component: Core (Cache system) Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

Snowflake requires all fields to be quoted, otherwise they're treated as uppercase.

The attached patch works with stable/3.2.x, but I'll have to review it once ​django-snowflake development is caught up to Django's main branch.

Attachments (1)

33340.diff​ (2.7 KB ) - added by Tim Graham 4 years ago.

Download all attachments as: .zip

Change History (7)

by Tim Graham, 4 years ago

Attachment: 33340.diff​ added

comment:1 by Mariusz Felisiak, 4 years ago

Easy pickings: set
Triage Stage: Unreviewed → Accepted

Thanks for the report.

comment:2 by Arsalan Ghassemi, 4 years ago

Owner: changed from nobody to Arsalan Ghassemi
Status: new → assigned

Hello, I'm adding the patch for this ticket, the topic branch : ​https://github.com/ArsaCode/django/tree/ticket_33340

Last edited 4 years ago by Arsalan Ghassemi (previous) (diff)

comment:3 by Arsalan Ghassemi, 4 years ago

Has patch: set

Hi,

I opened a PR for this issue : ​https://github.com/django/django/pull/15166

comment:4 by Mariusz Felisiak, 4 years ago

Patch needs improvement: set

comment:5 by Mariusz Felisiak, 4 years ago

Patch needs improvement: unset
Triage Stage: Accepted → Ready for checkin

comment:6 by Mariusz Felisiak <felisiak.mariusz@…>, 4 years ago

Resolution: → fixed
Status: assigned → closed

In 17df7211:

Fixed #33340 -- Fixed unquoted column names in queries used by DatabaseCache.

Note: See TracTickets for help on using tickets.
Back to Top