Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#32311 closed New feature (fixed)

Add system check for CSRF_FAILURE_VIEW setting

Reported by: Adam Johnson Owned by: Hasan Ramezani
Component: Core (System checks) Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by Adam Johnson)

Check #29642 added checks for the custom 400, 404, etc. error views. Similarly, a check should be added to ensure that the custom CSRF failure view as configured in the CSRF_FAILURE_VIEW setting exists and has the right function signature. There's otherwise no verification that it's well configured, and it will only fail when a CSRF error occurs.

Change History (10)

comment:1 by Adam Johnson, 5 years ago

Description: modified (diff)

comment:2 by Tim Graham, 5 years ago

Triage Stage: Unreviewed → Accepted

comment:3 by Hasan Ramezani, 5 years ago

Owner: changed from nobody to Hasan Ramezani
Status: new → assigned

comment:4 by Hasan Ramezani, 5 years ago

​PR

comment:5 by Adam Johnson, 5 years ago

Has patch: set
Patch needs improvement: set

comment:6 by Adam Johnson, 5 years ago

Btw Hasan, in future when you make a PR please check 'has patch' on Trac, otherwise it'll take longer for people to notice.

comment:7 by Hasan Ramezani, 5 years ago

Patch needs improvement: unset

comment:8 by Adam Johnson, 5 years ago

Triage Stage: Accepted → Ready for checkin

comment:9 by GitHub <noreply@…>, 5 years ago

Resolution: → fixed
Status: assigned → closed

In 64331419:

Fixed #32311 -- Added system check for CSRF_FAILURE_VIEW setting.

comment:10 by GitHub <noreply@…>, 5 years ago

In ba3fb2e4:

Refs #32311 -- Fixed CSRF_FAILURE_VIEW system check errors code.

Note: See TracTickets for help on using tickets.
Back to Top