Opened 5 years ago

Closed 5 years ago

#32208 closed Bug (fixed)

add filter is unable to concatenate strings with lazy string

Reported by: Claude Paroz Owned by: Hasan Ramezani
Component: Template system Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

If you try to concatenate a string with a lazy string with the add template filter, the result is always the empty string because the add filter generates an exception (TypeError: can only concatenate str (not "__proxy__") to str).

Attachments (1)

32208-tests.diff​ (784 bytes ) - added by Mariusz Felisiak 5 years ago.
Tests.

Download all attachments as: .zip

Change History (7)

by Mariusz Felisiak, 5 years ago

Attachment: 32208-tests.diff​ added

Tests.

comment:1 by Mariusz Felisiak, 5 years ago

Triage Stage: Unreviewed → Accepted

Thanks. I attached a test.

comment:2 by Blackeyeforreal, 5 years ago

Owner: changed from nobody to Blackeyeforreal
Status: new → assigned

comment:3 by Blackeyeforreal, 5 years ago

Has patch: set

comment:4 by Mariusz Felisiak, 5 years ago

Patch needs improvement: set

comment:5 by Mariusz Felisiak, 5 years ago

Owner: changed from Blackeyeforreal to Hasan Ramezani
Patch needs improvement: unset
Triage Stage: Accepted → Ready for checkin

​New PR

comment:6 by Mariusz Felisiak <felisiak.mariusz@…>, 5 years ago

Resolution: → fixed
Status: assigned → closed

In 577f2338:

Fixed #32208 -- Allowed adding lazy() objects.

Co-authored-by: Claude Paroz <claude@…>

Note: See TracTickets for help on using tickets.
Back to Top