Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#31777 closed New feature (fixed)

Custom collations

Reported by: Tom Carrick Owned by: Tom Carrick
Component: Database layer (models, ORM) Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by Tom Carrick)

Mailing list, but it didn't get any responses: https://groups.google.com/u/2/g/django-developers/c/djMQwwxtCVY

We have the various CI fields on postgres, but these are discouraged since pg12 in favour of nondeterministic collations. I think it'd be useful to have a way to do this in Django, though I'm not sure what the API would look like. My initial thought, knowing very little about the ORM, is a Collation class that can be passed into a model field, but I'm not sure.

PR

Change History (16)

comment:1 by Simon Charette, 4 years ago

Related to #21181, #9682, and #5745.

comment:2 by Carlton Gibson, 4 years ago

Resolution: needsinfo
Status: newclosed

Mailing list, but it didn't get any responses...

Hi Tom. I feel bad saying you need to go back to the mailing list, but without SOME proposal this isn't really actionable as it stands.

You've got Simon's attention now, so there's hope there... 🙂

Short of that, I'd suggest sketching up some ideas and following up your initial post. (Having just looked at it, it's a bit "Argh! no idea", at first glance.)

I'm going to close as needs info for now. Really happy to re-open either we have some suggestions for the API, or (less good) we're happy to leave it open even undefined, but then I'd probably want to mark it Someday/Maybe. I hope that makes sense.

comment:3 by Aymeric Augustin, 4 years ago

Resolution: needsinfo
Status: closednew

Hello Carlton, given that there's a PR that looks quite reasonable and a bit of support on the mailing list, I'm going to reopen and accept.

The ticket was short on details; the PR makes things clearer.

Essentially this is adding ORM support for a feature that most databases support. I'm not seeing obvious drawbacks. Hence, accepting.

comment:4 by Aymeric Augustin, 4 years ago

Triage Stage: UnreviewedAccepted

comment:5 by Carlton Gibson, 4 years ago

Super. Thanks!

comment:6 by Tom Carrick, 4 years ago

Owner: changed from nobody to Tom Carrick
Status: newassigned

comment:7 by Tom Carrick, 4 years ago

Description: modified (diff)
Has patch: set

comment:8 by Tom Carrick, 4 years ago

Triage Stage: AcceptedReady for checkin

comment:9 by Mariusz Felisiak, 4 years ago

Triage Stage: Ready for checkinAccepted

You shouldn't mark you own PRs as ready for checkin.

comment:10 by Mariusz Felisiak, 4 years ago

Patch needs improvement: set

comment:11 by Tom Carrick, 4 years ago

Patch needs improvement: unset

comment:12 by Mariusz Felisiak, 4 years ago

Patch needs improvement: set

comment:13 by Tom Carrick, 4 years ago

Patch needs improvement: unset

comment:14 by Mariusz Felisiak, 4 years ago

Triage Stage: AcceptedReady for checkin

comment:15 by Mariusz Felisiak <felisiak.mariusz@…>, 4 years ago

Resolution: fixed
Status: assignedclosed

In e387f191:

Fixed #31777 -- Added support for database collations to Char/TextFields.

Thanks Simon Charette and Mariusz Felisiak for reviews.

comment:16 by GitHub <noreply@…>, 4 years ago

In 292b3be6:

Refs #31777 -- Doc'd Char/TextField.db_collation parameter in MySQL notes.

Note: See TracTickets for help on using tickets.
Back to Top