[patch] object_list should accept lists as well as QuerySets

[Grimboy]

object_list should accept lists as well as QuerySets. This is perhaps a matter of opinion. Obviously getting access to a list in urls.py isn't practical. However, lots of people use generic views as a way to "finish off" real views. It therefore seems a bit limiting to only accept QuerySets. A view may parse some items in an xml file and return them as a list or may do a raw SQL query rather than using Django's ORM. So this is not an impractical addition.

I haven't renamed the queryset argument since it is often specified by keyword. Another, perhaps cleaner solution would be to rename queryset to sequence and accept queryset as a deprecated (or not) argument.

[Grimboy]

Using documentation conventions.

[frankie@…]

This version doesn't force what obviously aren't QuerySets to be passed in by queryset=* while keeping compatibility. Not sure if this is more or less confusing than the previous one.

[Gary Wilson <gary.wilson@…>]

Please note that #3181 was marked a duplicate of this and had an alternative patch.

[James Bennett]

I'd be +1 on this since it would mean generic views could work with other ORMs.

[frankie@…]

So we are currently +3 (me, arockstar@… of the other patch and ubernostrum) and -0. Anyone going to object or should this be moved onto ready for checkin?

[frankie@…]

Fixed silly bug from using if foo rather than if foo is not None. Against [4750].

[Chris Beaven]

I much prefer the version before another keyword was introduced.

Needs improvement because it should be using isinstance(queryset, QuerySet) in case it's a subclass.

[Jacob]

No, this is by design: generic views operate on querysets. If you need different behavior, you'll need to write your own views.