Django

Code

Ticket #3155 (closed: fixed)

Opened 2 years ago

Last modified 2 years ago

[patch] urlencode filter fails when passed an integer

Reported by: SmileyChris Assigned to: adrian
Milestone: Component: Template system
Version: Keywords: urlencode
Cc: Triage Stage: Ready for checkin
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

My code which is failing: 

<a href="...?id={{ user_id|urlescape }}">

user_id is sometimes an integer (when pulled from database), which caused urlescape to fail.

I could just str() it in the view, but it shouldn't really matter. The simple patch converts to a string if it isn't one already.

Attachments

urlencode.patch (448 bytes) - added by SmileyChris on 12/17/06 15:05:18.

Change History

12/17/06 15:05:18 changed by SmileyChris

  • attachment urlencode.patch added.

01/18/07 03:39:36 changed by Simon G. <dev@simon.net.nz>

  • keywords set to urlencode.
  • stage changed from Unreviewed to Ready for checkin.

02/12/07 23:50:55 changed by mtredinnick

  • status changed from new to closed.
  • resolution set to fixed.

(In [4496]) Fixed #3155 -- Allow an integer to be passed to the urlencode filter. Patch based on one from SmileyChris?.

Add/Change #3155 ([patch] urlencode filter fails when passed an integer)




Change Properties
Action