Opened 19 years ago

Closed 19 years ago

#3132 closed enhancement (fixed)

[patch] prefix support for newforms

Reported by: jkocherhans Owned by: Adrian Holovaty
Component: Forms Version:
Severity: normal Keywords:
Cc: jkocherhans@… Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description


Attachments (1)

newforms-prefix.diff​ (5.4 KB ) - added by jkocherhans 19 years ago.
Initial support and minimal tests. Needs more work, but feel free to nitpick.

Download all attachments as: .zip

Change History (8)

comment:1 by jkocherhans, 19 years ago

Summary: prefix support for newforms → [patch] prefix support for newforms

comment:2 by jkocherhans, 19 years ago

Cc: jkocherhans@… added

by jkocherhans, 19 years ago

Attachment: newforms-prefix.diff​ added

Initial support and minimal tests. Needs more work, but feel free to nitpick.

comment:3 by Adrian Holovaty, 19 years ago

Kudos to you for using the correct musical taste in the unit tests (Jim Morrison and John Lennon).

:)

comment:4 by Adrian Holovaty, 19 years ago

I see that the patch adds a period between the prefix and the field name. Are periods allowed in HTML id attributes? I think I'll change it to a hyphen...

comment:5 by Adrian Holovaty, 19 years ago

Looks like periods are indeed allowed in HTML id attributes, but they might mess up CSS targeting...

comment:6 by jkocherhans, 19 years ago

You're right about css now that I think about it. It's probably better to use a hyphen in the id. I like the period better in the name, but don't feel strongly either way. Hypens all around would be simpler if they are in the id tho.

comment:7 by Adrian Holovaty, 19 years ago

Resolution: → fixed
Status: new → closed

(In [4194]) Fixed #3132 -- Added prefix support for newforms. Thanks, jkocherhans

Note: See TracTickets for help on using tickets.
Back to Top