Filtering choices in admin list view don't respond to limit_choices_to parameter

[Archatas (aidas.bendoraitis at gmail.com)]

Administration list view shows choices in filters not responding to the limit_choices_to field for the field.

For example, if we have

class Color(models.Model):
    value=models.CharField(...)
    warm=models.BooleanField(...)

class Thing(models.Model):
    title=models.CharField(...)
    color=models.ForeignKey(Color, limit_choices_to={'warm': True})
    class Admin:
        list_filter = ('color',)

We will get all the choices of Color objects listed in the Filter/By Color section instead of getting only those, which are warm.

To fix this, the line

self.lookup_choices = f.rel.to._default_manager.all()

at class RelatedFilterSpec(FilterSpec) in the file django/contrib/admin/filterspecs.py has to be changed to

if f.rel.limit_choices_to:
    self.lookup_choices = f.rel.to._default_manager.filter(**f.rel.limit_choices_to)
else:
    self.lookup_choices = f.rel.to._default_manager.all()

[(none)]

Milestone Version 1.0 deleted

[Gary Wilson <gary.wilson@…>]

This seems like the logical thing to do. If someone disagrees, feel free to set back to decision needed. Can someone provide a real patch please.

[Robert Myers <myer0052@…>]

filterspecs limit_choices_to patch

[Robert Myers <myer0052@…>]

I tested out the patch and it works. Not sure it this should have a unit test or not it seems really simple and none of the other filters are currently being tested.

[Archatas]

I found one case, where it fails: that is when Q() objects instead of dictionaries are used to limit the choices. Here is the simple fix:

if f.rel.limit_choices_to:
    if type(f.rel.limit_choices_to).__name__ == "dict":
        self.lookup_choices = f.rel.to._default_manager.filter(**f.rel.limit_choices_to)
    else:
        self.lookup_choices = f.rel.to._default_manager.filter(f.rel.limit_choices_to)
else:
    self.lookup_choices = f.rel.to._default_manager.all()

[rob.slotboom at wanadoo.nl]

The patch by Archatas doesn't work with the following limit_choices_to:

limit_choices_to = {'parentisnull': False}

[Will Hardy]

Take limit_choices_to into account for list_filter in Admin

[anonymous]

The same thing is done in the get_choices() method in /django/db/models/fields/__init__.py, ideally we would reuse this, but because I don't want to rewrite a function I don't completely understand, I have just copied the approach taken in get_choices().

The patch I just attached should work exactly the same way as get_choices().

[Brian Rosner]

The admin code in trunk won't be updated. Moving this to newforms-admin. It does look to still be a problem in that branch. Please submit patches against newforms-admin.

[Malcolm Tredinnick]

(Please don't change ticket titles to make them less readable by chewing up space with an unnecessary prefix. We already have the version field and patch checkboxes and the like to differentiate between things.)

[Will Hardy]

newforms-admin version of patch to take limit_choices_to into account for list_filter in Admin

[Gary Wilson]

formatted ticket description

[Karen Tracey <kmtracey@…>]

Problem originally reported against old admin, should not block merge of newforms-admin.

[Daniel Poelzleithner]

doesn't matter as the problem still exists and is major as it may render admin pages unusable.

[Ivan Sagalaev <Maniac@…>]

Patch using get_choices

[Ivan Sagalaev <Maniac@…>]

As suggested by comment:7 new patch uses field's get_choices to construct a list of (id, title) pairs. Though a bit bigger (3 lines instead of 1) this looks cleaner to me.

[Karen Tracey]

(In [9241]) Fixed #3096 -- Make admin list_filters respect limit_choices_to.

[Karen Tracey]

(In [9242]) [1.0.X] Fixed #3096 -- Make admin list_filters respect limit_choices_to.

Backport of [9241] from trunk.