Django

Code

Ticket #3080 (closed: fixed)

Opened 2 years ago

Last modified 2 years ago

[bug] delete_cookie method imporoperly sets the domain parameter in django/http/!__init!__.py

Reported by: nowell strite Assigned to: adrian
Milestone: Component: Core framework
Version: SVN Keywords:
Cc: Triage Stage: Unreviewed
Has patch: 0 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

In django/http/__init__.py the delete_cookie method improperly sets the domain parameter to the path parameter. Below is a patch that corrects the oversight. 

Index: django/http/__init__.py
===================================================================
--- django/http/__init__.py	(revision 4126)
+++ django/http/__init__.py	(working copy)
@@ -208,7 +208,7 @@
         if path is not None:
             self.cookies[key]['path'] = path
         if domain is not None:
-            self.cookies[key]['domain'] = path
+            self.cookies[key]['domain'] = domain
         self.cookies[key]['expires'] = 0
         self.cookies[key]['max-age'] = 0

Attachments

Change History

11/29/06 10:44:10 changed by adrian

  • status changed from new to closed.
  • resolution set to fixed.

(In [4135]) Fixed #3080 -- Fixed bug in delete_cookie() method. Thanks, nowell strite

01/17/07 16:12:17 changed by

  • milestone deleted.

Milestone Version 1.0 deleted

Add/Change #3080 ([bug] delete_cookie method imporoperly sets the domain parameter in django/http/!__init!__.py)




Change Properties
Action