Django

Code

Ticket #3062 (closed: fixed)

Opened 2 years ago

Last modified 4 months ago

[patch] Remove arbitrary maxlength from UserCreationForm and PasswordChangeForm password fields

Reported by: Collin Grady <cgrady@the-magi.us> Assigned to: nobody
Milestone: Component: Contrib apps
Version: Keywords:
Cc: Triage Stage: Accepted
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

At present, UserCreationForm? and PasswordChangeForm? have arbitrary maxlengths on the input fields for the password (and not even the same max).

As the auth code itself has no such max length limit, this serves no purpose but to cause longer passwords to fail. While not a common occurance, it did recently pop up, so there is at least some need for longer passwords :)

Attachments

password-maxlength-removal.patch (1.7 kB) - added by Collin Grady <cgrady@the-magi.us> on 11/24/06 17:47:49.
password-maxlength-removal.2.patch (2.3 kB) - added by Collin Grady <cgrady@the-magi.us> on 12/06/06 19:08:21.
new patch, missed a few maxlengths before

Change History

11/24/06 17:47:49 changed by Collin Grady <cgrady@the-magi.us>

  • attachment password-maxlength-removal.patch added.

11/24/06 17:52:06 changed by Collin Grady <cgrady@the-magi.us>

  • summary changed from [path] Remove arbitrary maxlength from UserCreationForm and PasswordChangeForm password fields to [patch] Remove arbitrary maxlength from UserCreationForm and PasswordChangeForm password fields.

12/06/06 19:08:21 changed by Collin Grady <cgrady@the-magi.us>

  • attachment password-maxlength-removal.2.patch added.

new patch, missed a few maxlengths before

01/19/07 18:57:09 changed by Simon G. <dev@simon.net.nz>

  • stage changed from Unreviewed to Design decision needed.

09/16/07 10:08:48 changed by ubernostrum

  • stage changed from Design decision needed to Accepted.

The auth forms need to be rewritten for newforms anyway and this can be done as part of that refactoring, but there are some tricky dependencies. Collin, do you feel like taking that on?

08/01/08 16:18:17 changed by lukeplant

  • status changed from new to closed.
  • resolution set to fixed.

(In [8180]) Fixed #3062 - removed arbitrary and unneeded max_length on password fields in auth forms.

Add/Change #3062 ([patch] Remove arbitrary maxlength from UserCreationForm and PasswordChangeForm password fields)




Change Properties
Action