Django

Code

Ticket #3037 (closed: fixed)

Opened 1 year ago

Last modified 3 weeks ago

Q(a=1, b=2) treated as Q(a=1) | Q(b=2)

Reported by: Andrew McNabb <amcnabb@mcnabbs.org> Assigned to: nobody
Component: Database wrapper Version: SVN
Keywords: qs-rf-fixed Cc:
Triage Stage: Accepted Has patch: 0
Needs documentation: 0 Needs tests: 0
Patch needs improvement: 0

Description

As far as I can tell from the documentation, arguments to a Q are anded together, e.g. Q(a=1, b=2) is equivalent to Q(a=1) & Q(b=2). However, I am currently finding (in revision 4085) that Q(a=1, b=2) is instead equivalent to Q(a=1) | Q(b=2). In this particular case, I am doing something like:

q1 = Q(a=1, b=2)

q2 = Q(a=3, b=4)

model.objects.filter(q1 | q2)

When I look at connection.queries, I find that there is no parenthesization at all, and all of the terms are combined with OR like "a=1 OR b=2 OR a=3 OR b=4" instead of "(a=1 AND b=2) OR (a=3 AND b=4)".

I made my description a little bit abstract for clarity, but I can post the exact queries if necessary. Right now I'm working around the problem by doing something of the form:

q1 = Q(a=1) & Q(b=2)

etc., which gives the query I expected. I hope this report is clear. Let me know if you have any questions.

Attachments

Change History

02/13/07 15:16:01 changed by Simon G. <dev@simon.net.nz>

  • stage changed from Unreviewed to Design decision needed.

02/13/07 16:44:49 changed by mtredinnick

  • owner changed from adrian to mtredinnick.
  • stage changed from Design decision needed to Accepted.

Yeah, this is broken. It will be fixed post-0.96 (but pre-1.0), since fixing all the problems with disjunctive and conjunctive queries (as well as join types, etc) requires a large refactoring of the QuerySet class. I'm working on this area, so I'll take this one.

09/15/07 13:21:01 changed by ikelly

  • keywords set to qs-rf.

10/14/07 19:48:40 changed by mtredinnick

(In [6514]) queryset-refactor: Added a test to show that #3037 is really fixed. Refs #3037.

10/14/07 19:51:32 changed by mtredinnick

  • keywords changed from qs-rf to qs-rf-fixed.

04/26/08 21:50:16 changed by mtredinnick

  • status changed from new to closed.
  • resolution set to fixed.

(In [7477]) Merged the queryset-refactor branch into trunk.

This is a big internal change, but mostly backwards compatible with existing code. Also adds a couple of new features.

Fixed #245, #1050, #1656, #1801, #2076, #2091, #2150, #2253, #2306, #2400, #2430, #2482, #2496, #2676, #2737, #2874, #2902, #2939, #3037, #3141, #3288, #3440, #3592, #3739, #4088, #4260, #4289, #4306, #4358, #4464, #4510, #4858, #5012, #5020, #5261, #5295, #5321, #5324, #5325, #5555, #5707, #5796, #5817, #5987, #6018, #6074, #6088, #6154, #6177, #6180, #6203, #6658

Add/Change #3037 (Q(a=1, b=2) treated as Q(a=1) | Q(b=2))




Change Properties
Action