Django

Code

Ticket #3031 (closed: fixed)

Opened 2 years ago

Last modified 8 months ago

date_based.archive_month includes too much

Reported by: ubernostrum Assigned to: robh
Milestone: Component: Generic views
Version: SVN Keywords: sprintsept14
Cc: Triage Stage: Accepted
Has patch: 0 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

Per a report on the django-users list, it appears that the fix from #992, which was necessary at the time, is no longer necessary and now causes the archive_month view to include too many days.

Attachments

Change History

05/11/07 12:05:47 changed by pat.j.anderson@gmail.com

  • version set to SVN.

I'm not sure if what I have noticed in how date_based generic views work is related to this ticket, but I'll post my observation here, and see if you can confirm it.

I'm using the latest trunk (#5194) with python 2.5 on ubuntu feisty with MySQL 5.0.38.

'archive_month' includes 'Feb-01' if I query for the month of January, but 'archive_year' strips 'Jan-01', while the first day of other months is shown.

05/11/07 18:25:31 changed by Gary Wilson <gary.wilson@gmail.com>

  • stage changed from Unreviewed to Accepted.

08/13/07 13:22:04 changed by ubernostrum

Discussion on django-developers is here.

09/15/07 23:08:01 changed by robh

  • keywords set to sprintsept14.
  • owner changed from nobody to robh.
  • status changed from new to assigned.

This seems to have been fixed somewhere along the line, and I've written tests to prove it.

I haven't separated the patch out from #317 because it's starting to feel like they might as well be the same patch: "Provide basic tests for date-based generic views".

09/16/07 00:00:58 changed by robh

  • status changed from assigned to closed.
  • resolution set to fixed.

I've included patch for this in #5506 -- the particlar bug this ticket talks about is apparently no longer present, but the test in #5506 should make sure that it never comes back.

10/24/07 08:05:05 changed by patrick@vonautomatisch.at

i´m using rev 6023 and this issue doesn´t seem to be solved.

Add/Change #3031 (date_based.archive_month includes too much)




Change Properties
Action