Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#30013 closed Cleanup/optimization (fixed)

Fix compatiblity with mysqlclient 1.3.14

Reported by: Tim Graham Owned by: Tim Graham
Component: Database layer (models, ORM) Version: 2.1
Severity: Normal Keywords:
Cc: Ed Morley Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

mysqlclient 1.3.14 broke DatabaseOperations.last_executed_query() by removing ​_last_executed in ​PR #283.

Change History (9)

comment:1 by Tim Graham, 7 years ago

Has patch: set

​PR

comment:2 by Tim Graham, 7 years ago

I added a commit to the PR to fix backends.mysql.test_schema.SchemaEditorTests.test_quote_value (value=1.754) following ​https://github.com/PyMySQL/mysqlclient-python/commit/09018914e1f271afc1aee2c2f233a59032f9effc.

comment:3 by Tim Graham <timograham@…>, 7 years ago

Resolution: → fixed
Status: assigned → closed

In 284b3221:

Fixed #30013 -- Fixed DatabaseOperations.last_executed_query() with mysqlclient 1.3.14+.

comment:4 by Tim Graham <timograham@…>, 7 years ago

In 734ce71:

Refs #30013 -- Fixed SchemaEditor.quote_value() test for mysqlclient 1.3.14+.

comment:5 by Tim Graham <timograham@…>, 7 years ago

In 10849069:

[2.1.x] Fixed #30013 -- Fixed DatabaseOperations.last_executed_query() with mysqlclient 1.3.14+.

Backport of 284b3221a2c17af5bfe2edbf851ac0a9901f91a0 from master.

comment:6 by Tim Graham <timograham@…>, 7 years ago

In 389ef05:

[2.1.x] Refs #30013 -- Fixed SchemaEditor.quote_value() test for mysqlclient 1.3.14+.

Backport of 734ce71824180740f2318750ae2436f4b60c30b1 from master.

comment:7 by GitHub <noreply@…>, 7 years ago

In 13501d1:

[2.0.x] Refs #30013 -- Doc'd that mysqlclient 1.3.14 and later isn't supported.

comment:8 by Tim Graham <timograham@…>, 7 years ago

In 2ea1e0e5:

[1.11.x] Refs #30013 -- Doc'd that mysqlclient 1.3.14 and later isn't supported.

comment:9 by Ed Morley, 7 years ago

Cc: Ed Morley added
Note: See TracTickets for help on using tickets.
Back to Top