Django

Code

Ticket #2991 (closed: fixed)

Opened 2 years ago

Last modified 2 years ago

Adding Message-ID header in core/mail.py

Reported by: Graham King <graham@darkcoding.net> Assigned to: adrian
Milestone: Component: Core framework
Version: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: 0 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

At the moment django.core.mail does not set a Message-ID header in the mails it sends.

SpamAssassin spots this and says INVALID_MSGID and /or MSGID_NO_HOST. With clustered mail servers (Exchange at least) if both members of the cluster receive a message without a message-id, they can think it is the same message and one of the messages will be dropped. I think the Message-ID is also used for message threading. Hence Message-ID is a good thing.

I suggest changing django.core.mail.send_mass_mail to include the attached patch, which adds a Message-ID header according to the format recommended here:

http://www.jwz.org/doc/mid.html

http://rfc.sunsite.dk/rfc/rfc822.html

Attachments

django-mail-message-id.diff (0.7 kB) - added by Graham King <graham@darkcoding.net> on 11/07/06 04:12:53.
svn diff

Change History

11/07/06 04:12:53 changed by Graham King <graham@darkcoding.net>

  • attachment django-mail-message-id.diff added.

svn diff

11/07/06 09:32:19 changed by jacob

  • status changed from new to closed.
  • resolution set to fixed.

(In [4051]) Fixed #2991: Added Message-ID header to messages sent from Django. Thanks, Graham King.


Add/Change #2991 (Adding Message-ID header in core/mail.py)




Change Properties
Action