[patch] Add extension support to Markdown filter

diff for adding extention support to markdown

markup.diff in proper format

Are the older versions of MarkDown? going to have problems with these extensions?

Added check for older versions of Markdown, in which case the extensions are ignored silently.

Just added a updated patch which checks for older versions of Markdown. Unfortunately, Markdown only identifies the version in the doc string, so is was easier to wrap the call in a try, except block. Perhaps it would be better to wait for the newer versions of Markdown to become more common and defer this for then.

Personally, I copied the contrib app to my project and made the changes there. Anyone else is able to do the same.

Alternate version of other patches

Added a patch which cobbles together useful features from various patches:

• Exception trapping for no Markdown.
• Not using extensions on older versions of Markdown.
• Running escape(linebreaks(value)) when no Markdown is available, to safely handle the input.

just silently ignoring the "safe" extension seems to be a possible source of security problems...

Replying to alex@gc-web.de:

just silently ignoring the "safe" extension seems to be a possible source of security problems...

I understand the concern, but allowing raw html in Markdown is generally considered a feature - which some will want/expect. Therefore, it should be left to each site developer to chose for him/herself whether markdown should use safe mode in that particular app according to the needs of that projects users. The above patch does that.

Regarding the fact that safe mode is ignored in older versions, that is no different that the current behavior. If I recall correctly, it was not possible to call safe mode that easily, or at all, in older versions of Markdown. If anything, this adds one more reason to apply this patch.

Is there a way we could do the extension loading manually by using extension.extendMarkdown(markdown)? Currently, python-markdown's extension loading seems to require that packages be on sys.path. I think it would be nicer if you could do something like

{{ content|markdown:"myproject.utils.markdown_extension" }}

A SETTINGS variable that specifies the default extensions to use would be cool too.

Lets try this again, now that I'm logged in.

There is a problem with this patch in combination with mod_wsgi: when using the markdown filter without any arguments, arg is '', so extensions ends up being ['']. This causes markdown to print the following on stdout:

couldn't load extension (looking for mdx_ module)

when running under mod_wsgi this results in the following exception:

IOError: sys.stdout access restricted by mod_wsgi

because mod_wsgi disables writing to stdout. see http://code.google.com/p/modwsgi/wiki/DebuggingTechniques

It can be worked around by filtering out empty values: extensions = [e for e in arg.split(",") if e]

fix for stdout+mod_wsgi problem, please review wrt. unicode changes

To be expected of course, but this will fail with "markdown() takes exactly 1 non-keyword argument" if an older version of markdown is used (for instance 1.4, which is still the latest available in ubuntu feisty, debian etch, etc). Is it worthwhile to check markdown.version (an attr which doesn't exist in the older markdown.py) here and provide a more helpful error?

Address older versions of markdown and unicode support.

Patch updated to support the new auto-escaping

I just updated this patch to support the recently added auto-escaping. I left off the fallback to linebreaks(escape(text)) when markdown fails to import. IMO auto-escaping should be taking care of that - if not, then textile & restructuredtext should be patched as well. That's also why I left off the linebreaks - while its nice to have, it should be applied to all three processors, not just markdown - and therefore isn't relevant to this patch IMO.

(In [6834]) Fixed #2910 -- Added support for markdown extensions to the markdown markup filter (try saying that ten times quickly!). Thanks, Waylan Limberg.

I have problems using german umlauts with the markdown markup filter.

Using markdown.markdown(smart_unicode(value) instead of markdown.markdown(smart_str(value) in the returns solves the problem.

s = "öäüß"

print force_unicode(markdown.markdown(smart_str(s)))

MARKDOWN-CRITICAL: "UnicodeDecodeError?: Markdown only accepts unicode or ascii input."

print force_unicode(markdown.markdown(smart_unicode(s)))

<p>öäüß</p>

Duplicate: http://code.djangoproject.com/ticket/6387

Oops. 6387 is a duplicate of this. Sorry.

Replying to anonymous:

I have problems using german umlauts with the markdown markup filter. Using markdown.markdown(smart_unicode(value) instead of markdown.markdown(smart_str(value) in the returns solves the problem.

This is a result of stricter unicode enforcement for the newly released python-markdown 1.7 and not related to the extension support at all. In fact, this would have failed before the patch for this ticket was committed. Therefore, I am restoring this ticket to it's closed/fixed status and have opened a new ticket #6577, which has then been marked a duplicate of #6387.

Learn How to seduce women girls how to attract women guygetsgirl The Alpha Male System