Opened 8 years ago

Closed 8 years ago

#28407 closed New feature (duplicate)

Allow inspectdb to introspect db column comments

Reported by: 007 Owned by: nobody
Component: Database layer (models, ORM) Version: 1.11
Severity: Normal Keywords: db comment
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: yes Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by 007)

when use inspectdb make model from db.
the db column is created by dba, not developer .
so db column comments set to models Field is helpful for developer.
like

field = models.IntegerField(blank=True, null=True) #comments in db

​https://github.com/django/django/pull/8770

Change History (5)

comment:1 by 007, 8 years ago

Description: modified (diff)

comment:2 by Tim Graham, 8 years ago

Has patch: set
Needs tests: set
Summary: add db column comments to models Field comment_note → Allow inspectdb to introspect db column comments
Triage Stage: Unreviewed → Accepted

I think the comment should be prefixed with something like Column comment: . Also tests are required.

comment:3 by 007, 8 years ago

sorry i donot know how can i add a db with comment in tests.

comment:4 by Tim Graham, 8 years ago

I think it would involve something like adding a BaseDatabaseSchemaEditor.sql_create_column_comment attribute with the SQL for creating a column comment. Then the test can use that.

comment:5 by Tim Graham, 8 years ago

Resolution: → duplicate
Status: new → closed

Adding column comments as a model field option is accepted in #18468.

Note: See TracTickets for help on using tickets.
Back to Top