Django

Code

Ticket #2732 (closed: fixed)

Opened 2 years ago

Last modified 2 years ago

[patch] Fix FastCGI documentation in the shared-hosting case

Reported by: James Crasta <jcrasta@gmail.com> Assigned to: jacob
Milestone: Component: Documentation
Version: SVN Keywords: documentation fastcgi
Cc: Triage Stage: Unreviewed
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

When I wrote the fastcgi documentation, I mistakenly put in leading slashes on the RewriteRule?, which will not work when using mod_rewrite in .htaccess; This patch fixes that documentation.

Also, I made a small one-line change to core/servers/fastcgi.py to allow it to take keyword-args, updated the documentation to reflect.

Attachments

django-fastcgi-docfix.diff (1.3 kB) - added by James Crasta <jcrasta@gmail.com> on 09/14/06 08:45:22.
FastCGI documentation fix
django-fastcgi-runfastcgi-minorfix.diff (429 bytes) - added by James Crasta <jcrasta@gmail.com> on 09/14/06 14:20:25.
Minor fix to allow the first argument to runfastcgi to be optional, thus making calling it with kwargs useful

Change History

09/14/06 08:45:22 changed by James Crasta <jcrasta@gmail.com>

  • attachment django-fastcgi-docfix.diff added.

FastCGI documentation fix

09/14/06 10:37:11 changed by adrian

  • status changed from new to closed.
  • resolution set to fixed.

(In [3759]) Fixed #2732 -- Fixed error in FastCGI docs and added keyword-arg support in a FastCGI function. Thanks for the patch, James Crasta

09/14/06 14:20:25 changed by James Crasta <jcrasta@gmail.com>

  • attachment django-fastcgi-runfastcgi-minorfix.diff added.

Minor fix to allow the first argument to runfastcgi to be optional, thus making calling it with kwargs useful

09/14/06 14:22:55 changed by James Crasta <jcrasta@gmail.com>

  • status changed from closed to reopened.
  • resolution deleted.

I realized that adding the cleaner kwargs syntax wouldn't be all that useful if the first argument to runfastcgi was still required... you'd need to pass an empty list then. I added a one-line patch to fix that.

I figured since this is related to the same addition, I'd just reopen the ticket rather than creating another

09/21/06 08:45:24 changed by mtredinnick

  • status changed from reopened to closed.
  • resolution set to fixed.

(In [3777]) Fixed #2732 -- Allow first positional argument to runfastcgi() to be optional. Patch from James Crasta.

Add/Change #2732 ([patch] Fix FastCGI documentation in the shared-hosting case)




Change Properties
Action