Django

Code

Ticket #2664 (closed: fixed)

Opened 2 years ago

Last modified 2 years ago

[per-object-permissions] pop admin broken (2)

Reported by: Joeboy Assigned to: clong
Milestone: Component: Admin interface
Version: Keywords: per-object-permissions, row-level
Cc: django25@joebutton.co.uk Triage Stage: Unreviewed
Has patch: 0 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

This snippet from row_level_permissions.py looks wrong: 

        if r.owner_ct.id is user_ct.id:
            user_rlp_form_list.append({'form':forms.FormWrapper(edit_rlp_manip, data, rlp_errors), 'rlp':r})
        elif r.owner_ct.id is group_ct.id:
            group_rlp_form_list.append({'form':forms.FormWrapper(edit_rlp_manip, data, rlp_errors), 'rlp':r})            
        else:
            other_rlp_form_list.append({'form':forms.FormWrapper(edit_rlp_manip, data, rlp_errors), 'rlp':r})

as the ifs never evaluate to true. If I change the is's to =='s then they do evaluate to true when expected.

Attachments

Change History

09/06/06 12:54:13 changed by anonymous

  • cc set to django25@joebutton.co.uk.

09/06/06 15:38:54 changed by anonymous

  • owner changed from adrian to clong.

09/06/06 20:28:37 changed by clong

  • status changed from new to closed.
  • resolution set to fixed.

(In [3731]) [per-object-permissions] Fixes #2664 and #2663

Add/Change #2664 ([per-object-permissions] pop admin broken (2))




Change Properties
Action