Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#25900 closed Bug (fixed)

CommonMiddleware's USE_ETAGS broken

Reported by: Derek J. Curtis Owned by: nobody
Component: Core (Cache system) Version: 1.9
Severity: Normal Keywords: ETags
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

ETag support is broken in CommonMiddleware

This appears to have been broken here: ​https://github.com/django/django/commit/7a40fef17ab7918cbb1ddc3ba080f42b420f7a48#diff-1f8be0eae49a1bf37d52829eaeda6a4e

django.utils.cache.get_conditional_response's etag argument needs to be *unquoted*, however the etag passed by CommonMiddleware's make_response is quoted.

Pull Request with Regression Test: ​https://github.com/django/django/pull/5803

Change History (4)

comment:1 by Derek J. Curtis, 10 years ago

Type: Uncategorized → Bug

comment:2 by Tim Graham, 10 years ago

Easy pickings: unset
Triage Stage: Unreviewed → Ready for checkin

comment:3 by Tim Graham <timograham@…>, 10 years ago

Resolution: → fixed
Status: new → closed

In 6be9589e:

Fixed #25900 -- Fixed regression in CommonMiddleware ETag support.

comment:4 by Tim Graham <timograham@…>, 10 years ago

In 364d7d9:

[1.9.x] Fixed #25900 -- Fixed regression in CommonMiddleware ETag support.

Backport of 6be9589eb34f79914666c9d9e1e15bdb7fc44df2 from master

Note: See TracTickets for help on using tickets.
Back to Top