Opened 10 years ago
Closed 10 years ago
#25784 closed Cleanup/optimization (fixed)
help on collect_static fails if no STATIC_ROOT is defined
| Reported by: | Rapolas K. | Owned by: | Alex Morozov |
|---|---|---|---|
| Component: | contrib.staticfiles | Version: | dev |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Ready for checkin | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | yes | UI/UX: | no |
Description
I wanted to read what collect_static command does and typed: ./manage.py help collect_static. Instead of seeing the help text, I got ImproperlyConfigured exception about attempt to use collect_static with missing STATIC_ROOT setting. I don't think trying to read help text should raise an exception. I've tried with 1.8.6 and 1.9rc1 versions.
Change History (9)
comment:1 by , 10 years ago
| Component: | Uncategorized → contrib.staticfiles |
|---|---|
| Triage Stage: | Unreviewed → Accepted |
| Type: | Uncategorized → Cleanup/optimization |
| Version: | 1.9rc1 → master |
comment:2 by , 10 years ago
| Easy pickings: | set |
|---|
Yes, it's easy if we make self.local a (cached?) property.
comment:7 by , 10 years ago
| Patch needs improvement: | unset |
|---|---|
| Triage Stage: | Accepted → Ready for checkin |
For future reference, don't forget to uncheck "Patch needs improvement" after you update it so that the ticket returns to the review queue.
Would be nice if not too difficult.