urlresolvers.reverse broken when reversing decorated views

[dcwatson@…]

I noticed when trying to use urlresolvers.reverse, if you pass a decorated function, you get the following error:

Tried test in module testproj.views. Error was: 'function' object has no attribute 'method'

Here's a simple setup to reproduce the error:

urls.py:

from django.conf.urls.defaults import *
urlpatterns = patterns('',
    ( r'^test/$', 'testproj.views.test' ),
    ( r'^test/(?P<section>.+)/$', 'testproj.views.sect' ),
)

views.py:

from django.core import urlresolvers
from django.views.decorators.cache import cache_page
from django.http import HttpResponse
def test( req ):
    s = urlresolvers.reverse( 'testproj.views.sect', kwargs={'section':'woot'} )
    return HttpResponse( s )
@cache_page( 60 )
def sect( req, section ):
    return HttpResponse( "section %s" % section )

Comment out the cache_page decorator and things work as expected...

[Adrian Holovaty]

#2713 was a duplicate.

[Chris Beaven]

Perhaps a solution is that all Django decorators have a property which returns the original function. Then reverse can try to use this property before falling back to the function itself.

[Chris Beaven]

This ticket is actually user error, the problem is that cache_page can't be used with Python 2.4 decorator syntax, because it expects the view and the arguments to be passed to it at once, so you'd have to do:

def sect(req, section):
    return HttpResponse("section %s" % section)
sect = cache_page(sect, 60)

This is actually a documentation bug (or the decorator format needs to change), but I'll submit a new ticket for that.

[Chris Beaven]

New ticket: #4919

[Malcolm Tredinnick]

This isn't a documentation error, it's a long-standing bug in the cache_page decorator. It's entirely consistent that it shoudl be able to be used as a decorator, it just doesn't have the subtlety in the implementation that some of our other decorators have to work like this.

There was/is a ticket open about this somewhere, but I can't find it right at the moment.

[Chris Beaven]

(and the ticket was #4149 sorry)