Django

Code

Ticket #2503 (closed: fixed)

Opened 2 years ago

Last modified 2 years ago

[patch] max_age should be max-age in HttpResponse.delete_cookie

Reported by: ludo Assigned to: adrian
Milestone: Component: Core framework
Version: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

The HttpResponse.delete_cookie method uses the 'max_age' key instead of 'max-age', resulting in a Cookie error raised by Cookie.py" in setitem with the following message: 'Invalid Attribute max_age'.

Mini-patch following.

Attachments

delete_cookie.diff (469 bytes) - added by ludo@qix.it on 08/09/06 08:11:17.

Change History

08/09/06 08:11:17 changed by ludo@qix.it

  • attachment delete_cookie.diff added.

08/09/06 08:11:36 changed by anonymous

  • summary changed from max_age should be max-age in HttpResponse.delete_cookie to [patch] max_age should be max-age in HttpResponse.delete_cookie.

08/09/06 10:40:24 changed by adrian

  • status changed from new to closed.
  • resolution set to fixed.

(In [3545]) Fixed #2503 -- Fixed HttpResponse.delete_cookie() to work properly. It now takes path and domain as optional keyword arguments.

Add/Change #2503 ([patch] max_age should be max-age in HttpResponse.delete_cookie)




Change Properties
Action