forms.GenericIPAddressField.to_python behaves differently to other CharField subclasses.

[Keryn Knight]

Other forms.fields.CharField subclasses (UUIDField, URLField), when they replace the to_python method, call super(..., self).to_python(...) before acting on the value.

GenericIPAddressField however, ​does not, which means it calls .strip() on the input, assuming the input is a string.

Thus, the following fails:

>>> GenericIPAddressField().to_python(1)
AttributeError: 'int' object has no attribute 'strip'

where the other aforementioned subclasses succeed in their functionality:

>>> URLField().to_python(1)
'http://1'
>>> UUIDField().to_python(1)
ValidationError: ['Enter a valid UUID.']

Because the call to super(...) ensures either '' or smart_text(...) is returned.

I think the fix is thus:

    def to_python(self, value):
        value = super(GenericIPAddressField, self).to_python(value).strip()  # this is the fix line.
        if value in self.empty_values:
            return ''
        if value and ':' in value:
            return clean_ipv6_address(value, self.unpack_ipv4)
        return value

[Tim Graham]

​PR

[Tim Graham <timograham@…>]

In 6123e613:

Fixed #24708 -- Handled non-string values in GenericIPAddressField.to_python()