Creating a model called Item breaks the admin "delete selected" action

[Michael Angeletti]

contrib/admin/templates/admin/includes/object_delete_summary.html contains the following:

    {% for model_name, object_count in model_count.items %}

Given a model named Item, this breaks the admin's "delete selected <model name>" action. The reason for this is that model_count looks something like this:

    {'items': 1}

Because Django templates resolves model_count.items to model_count['items'] (which, in the above example is 1), this results in the template system trying to iterate an integer.

Now, changing the offending line in the template to:

    {% for model_name, object_count in model_count.iteritems %}

incidentally addresses the issue, but due to ​PEP 469, this might not be the solution. And, (I say jokingly, but for completion sake) what happens when I name my model IterItem?

[Tim Graham]

It's a regression in Django 1.8.

[Tim Graham]

​PR

[Tim Graham <timograham@…>]

In 47b35b1844b2adc167e64674824873991e9c4c2b:

Fixed #24411 -- Avoided dict key/method clash in admin delete views.

[Tim Graham <timograham@…>]

In dfcdf64d475418ed579da2621e331cc4d03a78e5:

[1.8.x] Fixed #24411 -- Avoided dict key/method clash in admin delete views.

Backport of 47b35b1844b2adc167e64674824873991e9c4c2b from master