IncludeNode should use Template._render rather than Template.render

[Preston Timmons]

When Template.render is called, it creates a new stack on the context. It also potentially sets context.template and adds the context processors to RequestContext.

I'm pretty sure this is unnecessary since the IncludeNode already pushes to the context stack or creates a new context internally. Calling Template._render here would be a slight optimization and remove the need for the conditional logic to set context.template on toplevel_render.

All the tests seem to pass if this change is made.

[Adam Zapletal]

Pull request is here: ​https://github.com/django/django/pull/4479

[Preston Timmons]

Hi adamzap. I hope this isn't discouraging, but I'm going to close this ticket as invalid. There are subtle differences between context.push() and context.render_context.push() that I didn't understand when I opened this ticket. The former happens in the IncludeNode, but the latter as part of Template.render(). Although the tests don't catch it, changing to Template._render() here would introduce a bug for IncludeNode similar to #24555.

Anyhow, thanks for making a PR, but sorry I forgot to close this one earlier.

[Adam Zapletal]

No worries! I'm glad my patch helped with the closing of this ticket somehow ;)