Django

Code

Ticket #2410 (closed: fixed)

Opened 2 years ago

Last modified 2 years ago

[patch] Add id attribute to change list form to easily look up it in javascript.

Reported by: Alex Dedul Assigned to: adrian
Milestone: Component: django.contrib.admin
Version: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

Title says it all. One thing this patch changes more is opts.object_name.lower to opts.module_name in bodyclass block, because opts.module_name is exactly opts.object_name.lower.

Index: django/contrib/admin/templates/admin/change_form.html
===================================================================
--- django/contrib/admin/templates/admin/change_form.html   (revision 3439)
+++ django/contrib/admin/templates/admin/change_form.html   (working copy)
@@ -6,8 +6,8 @@
 {% endblock %}
 {% block stylesheet %}{% admin_media_prefix %}css/forms.css{% endblock %}
 {% block coltype %}{% if ordered_objects %}colMS{% else %}colM{% endif %}{% endblock %}
-{% block bodyclass %}{{ opts.app_label }}-{{ opts.object_name.lower }} change-form{% endblock %}
+{% block bodyclass %}{{ opts.app_label }}-{{ opts.module_name }} change-form{% endblock %}
 {% block breadcrumbs %}{% if not is_popup %}
 <div class="breadcrumbs">
      <a href="../../../">{% trans "Home" %}</a> &rsaquo;
@@ -18,10 +18,9 @@
   {% if has_absolute_url %}<li><a href="../../../r/{{ content_type_id }}/{{ object_id }}/" class="viewsitelink">{% trans "View on site" %}</a></li>{% endif%}
   </ul>
 {% endif %}{% endif %}
-<form {% if has_file_field %}enctype="multipart/form-data" {% endif %}action="{{ form_url }}" method="post">{% block form_top %}{% endblock %}
+<form {% if has_file_field %}enctype="multipart/form-data" {% endif %}action="{{ form_url }}" method="post" id="id_{{ opts.module_name }}_form">{% block form_top %}{% endblock %}
 <div>
 {% if is_popup %}<input type="hidden" name="_popup" value="1" />{% endif %}
 {% if opts.admin.save_on_top %}{% submit_row %}{% endif %}

Attachments

Change History

07/24/06 07:13:47 changed by Alex Dedul

Form could be accessed and as document.forms[0], but that looks a bit obscure, accessing by id is cleaner.

08/12/06 00:42:48 changed by adrian

  • status changed from new to closed.
  • resolution set to fixed.

(In [3568]) Fixed #2410 -- Added HTML ID attribute to <form> on admin change-list pages, for easy targetting with JavaScript? and CSS


Add/Change #2410 ([patch] Add id attribute to change list form to easily look up it in javascript.)




Change Properties
Action