Django

Code

Ticket #2391 (closed: fixed)

Opened 2 years ago

Last modified 1 year ago

title case not handling UTF8 correctly

Reported by: rob@audenaerde.org Assigned to: adrian
Milestone: Component: Template system
Version: Keywords: unicode-branch
Cc: Triage Stage: Accepted
Has patch: 1 Needs documentation: 0
Needs tests: 1 Patch needs improvement: 1

Description

Since Django is basically a UTF8 based platform, it should perfom .title() on utf-8 strings. It assumes unicode. I think this diff fixes the problem.

Attachments

titlecase.diff (0.5 kB) - added by rob on 07/21/06 03:52:11.

Change History

07/21/06 03:52:11 changed by rob

  • attachment titlecase.diff added.

07/21/06 09:43:52 changed by adrian

This patch assumes utf-8 encoding, which isn't safe to assume.

02/03/07 05:45:35 changed by Michael Radziej <mir@noris.de>

  • needs_better_patch set to 1.
  • has_patch set to 1.
  • needs_tests set to 1.
  • stage changed from Unreviewed to Accepted.

please modify this patch and use settings.DATABASE_ENCODING instead of utf8. If possible, please add a test case.

06/01/07 10:44:18 changed by DavidReynolds <david@reynoldsfamily.org.uk>

As far as I can thell there is no such thing as settings.DATABASE_ENCODING would DEFAULT_CHARSET not be better?

06/02/07 00:20:59 changed by mtredinnick

  • keywords set to unicode-branch.

This patch is no longer relevant in light of the UnicodeBranch. The problem has been fixed on that branch. I'll close it when the branch is merged.

(to answer your question, for curiosity's sake: yes.)

07/04/07 07:11:05 changed by mtredinnick

  • status changed from new to closed.
  • resolution set to fixed.

(In [5609]) Merged Unicode branch into trunk (r4952:5608). This should be fully backwards compatible for all practical purposes.

Fixed #2391, #2489, #2996, #3322, #3344, #3370, #3406, #3432, #3454, #3492, #3582, #3690, #3878, #3891, #3937, #4039, #4141, #4227, #4286, #4291, #4300, #4452, #4702


Add/Change #2391 (title case not handling UTF8 correctly)




Change Properties
Action