Opened 10 years ago
Closed 10 years ago
#23844 closed Cleanup/optimization (fixed)
Use topological sort for migration operation dependency resolution
Reported by: | Patryk Zawadzki | Owned by: | nobody |
---|---|---|---|
Component: | Migrations | Version: | dev |
Severity: | Normal | Keywords: | |
Cc: | info+coding@… | Triage Stage: | Ready for checkin |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
A fixed implementation is provided in https://github.com/django/django/pull/3546
The initial implementation was provided by vanschelven, accepted and commited as part of https://github.com/django/django/pull/3525. It however broke in Python 3 due to how __eq__
and __hash__
behave.
I opted not to provide a default implementation of deconstruct
method to avoid arguments moving between args
and kwargs
depending on invocation (like the deconstruction of model fields it always produces the canonical form).
Change History (3)
comment:1 by , 10 years ago
Cc: | added |
---|---|
Needs documentation: | set |
Patch needs improvement: | set |
Triage Stage: | Unreviewed → Accepted |
comment:2 by , 10 years ago
Needs documentation: | unset |
---|---|
Patch needs improvement: | unset |
Triage Stage: | Accepted → Ready for checkin |
comment:3 by , 10 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
I left some cosmetic comments and Carl says it needs to be rebased to apply cleanly and commits squashed.