Django

Code

Ticket #2348 (closed: fixed)

Opened 2 years ago

Last modified 2 years ago

[patch] Unbound local error when performing invalid query

Reported by: cmgreen@uab.edu Assigned to: adrian
Milestone: Component: Database layer (models, ORM)
Version: SVN Keywords:
Cc: kmtracey@gmail.com Triage Stage: Ready for checkin
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

When performing a model query with an invalid keyword, I get an UnboundLocalError? rather than an error message saying it didn't know how to perform that type of query. I lost a bit of time trying to figure out how to debug this error but it was simplistic once I figured it out.

I used equals rather than exact 

   One.objects.filter(name__equals=1) 

sw/lib/python2.4/site-packages/django/db/models/query.py in lookup_inner(path, lookup_type, value, opts, table, column)
    845     if path:
    846         # There are elements left in the path. More joins are required.
--> 847         if len(path) == 1 and path[0] in (new_opts.pk.name, None) \
    848             and lookup_type in ('exact', 'isnull') and not join_required:
    849             # If the next and final name query is for a primary key,

UnboundLocalError: local variable 'new_opts' referenced before assignment
Out[22]: 
In [23]: One.objects.filter(name__equals=1)

Attachments

query.py.diff (0.7 kB) - added by Karen Tracey <kmtracey@gmail.com> on 01/07/07 18:10:38.
patch_with_test.diff (1.4 kB) - added by Karen Tracey <kmtracey@gmail.com> on 02/08/07 23:55:01.

Change History

07/13/06 21:34:30 changed by mtredinnick

This error won't ever be able to be reported as "invalid query type", because the lack of an invalid type just means we assume you have not specified one and append __exact to the end ("exact" is implied if nothing is given). The syntax you are using is valid for looking up the "equals" field in the related "name" model.

I suspect the actual error here is being caused by the same thing as #2287 (i.e. it's not clear why we are getting that far into the code). We can do a bit better in the error message, I suspect. This will need to wait until the current refactoring in django.db.model is completed, though.

07/29/06 16:04:41 changed by mtredinnick

(In [3490]) Seed the global app cache in a call to db.models.get_model() except when we are constructing a model class. Refs #2348.

07/29/06 16:06:11 changed by mtredinnick

Whoops! [3490] does not ref this bug at all -- it refers to #2438.

01/07/07 18:10:38 changed by Karen Tracey <kmtracey@gmail.com>

  • attachment query.py.diff added.

01/07/07 18:11:53 changed by Karen Tracey <kmtracey@gmail.com>

  • cc set to kmtracey@gmail.com.
  • summary changed from Unbound local error when performing invalid query to [patch] Unbound local error when performing invalid query.

I ran into this also today. I was surprised to get:

UnboundLocalError?: local variable 'new_opts' referenced before assignment

from File "/usr/lib/python2.4/site-packages/django/db/models/query.py", line 859, in lookup_inner

when I mistyped a filter specification as Dateear instead of Dateyear.

Granted, it's a user error, but for most other filter typos I get something more along the lines of:

TypeError?: Cannot resolve keyword 'xDate' into field

which clearly points me to where my typo is. UnboundLocalError? looks likes a bug in the Django code itself.

I looked at the code in query.py and it's a simple fix to catch cases like this and raise the TypeError? instead of continuing on and using variables that haven't been set. Is the refactoring mentioned above completed? I see query.py has been checked in quite recently so I am hoping the attached suggested patch could be useful in resolving this (and 2287, which looks to be the exact same problem).

02/08/07 22:25:44 changed by SmileyChris

  • needs_tests set to 1.
  • stage changed from Unreviewed to Accepted.

Looks good, is there a way to write a test for this? It'd make it easier for a committer to ensure the behaviour is correct.

02/08/07 23:55:01 changed by Karen Tracey <kmtracey@gmail.com>

  • attachment patch_with_test.diff added.

02/08/07 23:59:39 changed by Karen Tracey <kmtracey@gmail.com>

  • needs_tests deleted.

OK, I took a shot at adding a test for this (first time doing anything with the tests but it ran OK when I gave it a try). Patch + test are in the new attachment.

02/09/07 01:29:02 changed by SmileyChris

  • stage changed from Accepted to Ready for checkin.

Thanks, Karen -- well done on the patch + test. Usually we don't reference tickets, better to reference the problem directly in the comment, but a committer can fix that.

Good job and I look forwards to seeing some more patches from you ;)

02/09/07 21:39:56 changed by mtredinnick

  • status changed from new to closed.
  • resolution set to fixed.

(In [4470]) Fixed #2348 -- Improved error reporting when query filter arguments are misspelt. Variation on a patch from Karen Tracey.

Add/Change #2348 ([patch] Unbound local error when performing invalid query)




Change Properties
Action