lookup_allowed fails to consider dynamic list_filter

[Keryn Knight <django@…>]

Currently, lookup_allowed iterates over self.list_filter to determine valid params. This is technically incorrect since the introduction of get_list_filter() on ModelAdmin in 1.5, because it is possible to define a ModelAdmin such that self.list_filter is () but get_list_filter yields SimpleListFilter classes.

To correct it, the above code would need to change from:

for filter_item in self.list_filter:

to

for filter_item in self.get_list_filter(request):

The problem is that now lookup_allowed needs to accept request so that it can pass it back to get_list_filter

In Django itself, that's actually reasonably acceptable as a change, because ​it's used infrequently - the only place it's actually used is in ​ChangeList.get_filters, which has access to the request. However, it is overridden ​in the wild without accept *args, **kwargs, so it'd not be easy to provide a clean upgrade path.

[Simon Meers]

​https://github.com/django/django/pull/8856

[Sarah Boyce]

​https://github.com/django/django/pull/16759

[Mariusz Felisiak <felisiak.mariusz@…>]

In 594fcc2:

Fixed #22569 -- Made ModelAdmin.lookup_allowed() respect get_list_filter().

Thank you Simon Meers for the initial patch.

[Sarah Boyce <42296566+sarahboyce@…>]

In 8081557:

Refs #22569 -- Made request required in ModelAdmin.lookup_allowed() per deprecation timeline.