Django

Code

Ticket #223 (closed: fixed)

Opened 3 years ago

Last modified 1 year ago

[PATCH] Breadcrumb navigation broken in admin documentation

Reported by: Drew Amato <drewamato@gmail.com> Assigned to: adrian
Milestone: Component: django.contrib.admin
Version: Keywords:
Cc: Triage Stage: Accepted
Has patch: 0 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

The breadcrumb navigation in the admin documentation templates uses absolute references, rather than relative ones. This means that it won't work if you have your admin server running from anything other than the "root" directory.

Example:

My admin server is running at http://example.com:8000/admin/

But the code for the breadcrumb looks like this: 

<div class="breadcrumbs">
<a href="/">Home</a> &rsaquo;
<a href="/doc/">Documentation</a> &rsaquo;
<a href="/doc/models/">Models</a> &rsaquo; {{ name }}
</div>

Which means that the link for documentation (e.g.) will go to http://example.com:8000/doc/, instead of http://example.com:8000/admin/doc.

The links need to be changed to use the relative style links of the other page templates. e.g., 

<div class="breadcrumbs">
<a href="../../../">Home</a> &rsaquo; 
<a href="../../">Documentation</a> &rsaquo; 
<a href="../">Models</a> &rsaquo; {{ name }}
</div>

The affected files are in django/conf/admin_templates/doc

Attachments

broken_breadcrumbs.diff (5.0 kB) - added by Drew Amato <drewamato@gmail.com> on 07/29/05 05:20:25.
Simple Patch (svn diff results, for my working copy versus rev 335)

Change History

07/29/05 05:20:25 changed by Drew Amato <drewamato@gmail.com>

  • attachment broken_breadcrumbs.diff added.

Simple Patch (svn diff results, for my working copy versus rev 335)

07/29/05 06:47:13 changed by anonymous

  • summary changed from Breadcrumb navigation broken in admin documentation to [PATCH] Breadcrumb navigation broken in admin documentation.

07/29/05 10:18:26 changed by adrian

  • status changed from new to assigned.

07/29/05 10:25:33 changed by adrian

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [337]) Fixed #223 -- Changed breadcrumbs in admin doc templates to use relative, not absolute, URLs. Thanks, Drew Amato

Add/Change #223 ([PATCH] Breadcrumb navigation broken in admin documentation)




Change Properties
Action